This shows you the differences between two versions of the page.
Both sides previous revision Previous revision Next revision | Previous revision | ||
civilinfrastructureplatform:review-linux-4.4.176 [2019/03/21 10:03] pavelm [v4.4.176] |
civilinfrastructureplatform:review-linux-4.4.176 [2019/03/21 11:47] (current) pavelm [v4.4.176] |
||
---|---|---|---|
Line 22: | Line 22: | ||
ACK: pavel | ACK: pavel | ||
- f5aebe74113f x86: livepatch: Treat R_X86_64_PLT32 as R_X86_64_PC32 | - f5aebe74113f x86: livepatch: Treat R_X86_64_PLT32 as R_X86_64_PC32 | ||
- | pavel - too many signoffs, typo "effacted" in the changelog. | + | pavel -- too many signoffs, typo "effacted" in the changelog, typo "becauce" |
- 01fb36063d97 net: ipv4: use a dedicated counter for icmp_v4 redirect packets | - 01fb36063d97 net: ipv4: use a dedicated counter for icmp_v4 redirect packets | ||
- | UR: pavel | + | ACK: pavel -- changes ICMP behaviour from 2.6 without explaining why it is problematic. |
- 3fa6a285279f net: stmmac: Fix a race in EEE enable callback | - 3fa6a285279f net: stmmac: Fix a race in EEE enable callback | ||
- | UR: pavel | + | ACK: pavel |
- ffed570a85ad vxlan: test dev->flags & IFF_UP before calling netif_rx() | - ffed570a85ad vxlan: test dev->flags & IFF_UP before calling netif_rx() | ||
+ | ACK: pavel -- erm. "Should fix just one thing". | ||
- a466589807a1 tcp: clear icsk_backoff in tcp_write_queue_purge() | - a466589807a1 tcp: clear icsk_backoff in tcp_write_queue_purge() | ||
+ | ACK: pavel | ||
- 2e7b872833c7 net: Do not allocate page fragments that are not skb aligned | - 2e7b872833c7 net: Do not allocate page fragments that are not skb aligned | ||
+ | pavel -- theoretical bug, performance-only AFAICT | ||
- 122e4a307793 tcp: tcp_v4_err() should be more careful | - 122e4a307793 tcp: tcp_v4_err() should be more careful | ||
+ | pavel -- "make code more resilient for possible future bugs" | ||
- 817d4a429566 net: Add header for usage of fls64() | - 817d4a429566 net: Add header for usage of fls64() | ||
+ | ACK: pavel -- while changelog does not explain what the bug is, this should not break anything | ||
- 7fecacc0d5ff sky2: Increase D3 delay again | - 7fecacc0d5ff sky2: Increase D3 delay again | ||
+ | ACK: pavel | ||
- 1815d11b544a net: Fix for_each_netdev_feature on Big endian | - 1815d11b544a net: Fix for_each_netdev_feature on Big endian | ||
+ | pavel -- if I understand it correctly, this should be merged with 817d4a429566, otherwise it breaks compilation. | ||
- 27763b01a4ff hwmon: (lm80) Fix missing unlock on error in set_fan_div() | - 27763b01a4ff hwmon: (lm80) Fix missing unlock on error in set_fan_div() | ||
+ | ACK: pavel | ||
- 9d6ca4d88e27 vsock: cope with memory allocation failure at socket creation time | - 9d6ca4d88e27 vsock: cope with memory allocation failure at socket creation time | ||
+ | ACK: pavel | ||
- 9467d98f6d48 net: fix IPv6 prefix route residue | - 9467d98f6d48 net: fix IPv6 prefix route residue | ||
+ | ACK: pavel |