civilinfrastructureplatform:cipkernelmaintenance
Differences
This shows you the differences between two versions of the page.
| Both sides previous revision Previous revision | Next revision Both sides next revision | ||
|
civilinfrastructureplatform:cipkernelmaintenance [2017/12/13 18:23] bwhct [Read the commit message] Improve formatting of the command lines |
civilinfrastructureplatform:cipkernelmaintenance [2017/12/13 18:24] bwhct [Read the code] Fix formatting of code |
||
|---|---|---|---|
| Line 125: | Line 125: | ||
| * Ignore white-space changes - they shouldn't be combined with fixes, but at least they won't do any harm). | * Ignore white-space changes - they shouldn't be combined with fixes, but at least they won't do any harm). | ||
| * If a file contains multiple similar blocks of code, is the right one being patched? | * If a file contains multiple similar blocks of code, is the right one being patched? | ||
| - | * If the patch changes a function to acquire and then release a lock or other resource, are there any additional paths through the function where the resource can leak? For example, there might be an extra //return// statement in the stable branch, compared to the upstream version. | + | * If the patch changes a function to acquire and then release a lock or other resource, are there any additional paths through the function where the resource can leak? For example, there might be an extra ''return'' statement in the stable branch, compared to the upstream version. |
| - | * If the patch adds a //return//, //goto//, or //break// statement, again check for leaks. | + | * If the patch adds a ''return'', ''goto'', or ''break'' statement, again check for leaks. |
| * Sometimes the upstream commit will have been modified (backported) to create the stable patch, because it depended on new or changed APIs, or because a function that needed to be fixed has been merged or split up in some way. If it has been backported, do the modifications make sense? If someone other than the original author backported it, they should have added an explanation in the new commit message. | * Sometimes the upstream commit will have been modified (backported) to create the stable patch, because it depended on new or changed APIs, or because a function that needed to be fixed has been merged or split up in some way. If it has been backported, do the modifications make sense? If someone other than the original author backported it, they should have added an explanation in the new commit message. | ||
| * If the patch changes the type or semantics of a function, all its callers probably need to be updated. In the stable branch, there might be additional callers compared to upstream. Have any of them been missed? | * If the patch changes the type or semantics of a function, all its callers probably need to be updated. In the stable branch, there might be additional callers compared to upstream. Have any of them been missed? | ||
civilinfrastructureplatform/cipkernelmaintenance.txt · Last modified: 2023/09/28 06:49 by jki-siemens
Page Tools
Except where otherwise noted, content on this wiki is licensed under the following license: CC Attribution-Noncommercial-Share Alike 4.0 International
